Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix splitting of en locale codes according to DeepL requierements #739

Closed
wants to merge 1 commit into from
Closed

Fix splitting of en locale codes according to DeepL requierements #739

wants to merge 1 commit into from

Conversation

unreadableusername
Copy link

Added American and British English locales to translation target locale array.
fixes #738

@unreadableusername
Copy link
Author

unreadableusername commented Nov 7, 2023

I see the checks fail, but judging from the output this has nothing to do with my small change, but rather with some dev dependencies that might need a bump right? I am just anxious because this is my first contribution 🥳

@zerolab
Copy link
Collaborator

zerolab commented Nov 7, 2023

We have some Netlify jobs that fail and are on the list to be replaced. Triggered the actual CI tasks (they require approval to be run on PRs from first time contributors)

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e1051b0) 92.65% compared to head (5a78a67) 92.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files          46       46           
  Lines        4002     4002           
  Branches      596      596           
=======================================
  Hits         3708     3708           
  Misses        174      174           
  Partials      120      120           
Files Coverage Δ
wagtail_localize/machine_translators/deepl.py 66.66% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerolab
Copy link
Collaborator

zerolab commented Nov 15, 2023

Added tests and merged in a3efa8f
Thank you

@zerolab zerolab closed this Nov 15, 2023
@unreadableusername unreadableusername deleted the feature/target_specific_en_locales branch November 20, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepL target_lang for EN-GB and EN-US
4 participants