Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating tests as .assertFormError() is removed in Django 5 #754

Merged
merged 1 commit into from
Dec 20, 2023
Merged

updating tests as .assertFormError() is removed in Django 5 #754

merged 1 commit into from
Dec 20, 2023

Conversation

softquantum
Copy link
Contributor

No description provided.

@softquantum
Copy link
Contributor Author

softquantum commented Dec 20, 2023

I tested with tox locally and all tests passed, why is the test deployment failing ?
Also when adding Django 5 in the mix the modeladmin seems to be where some tests are still faililng, I still need to figure out the logs. Any info would help :). Willing to work on this. Merry Christmas :)

@zerolab
Copy link
Collaborator

zerolab commented Dec 20, 2023

Those are Netlify errors (on the list to move away from hosting docs there)
Just triggered the proper CI jobs.

Also, any chance you could fold in the changes from #747? So as to actually test with Django 5.0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a458ed8) 92.58% compared to head (2f54860) 92.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   92.58%   92.62%   +0.03%     
==========================================
  Files          47       47              
  Lines        4034     4054      +20     
  Branches      600      600              
==========================================
+ Hits         3735     3755      +20     
  Misses        177      177              
  Partials      122      122              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@softquantum
Copy link
Contributor Author

softquantum commented Dec 20, 2023

Those are Netlify errors (on the list to move away from hosting docs there) Just triggered the proper CI jobs.

Also, any chance you could fold in the changes from #747? So as to actually test with Django 5.0

I added the deps locally already and had still tests issues around modeladmin. Not sure where to look as the log is a bit weird.

@zerolab
Copy link
Collaborator

zerolab commented Dec 20, 2023

I am happy to merge this as is, and we can focus on the rest of the errors.
Not sure what's happening there without looking into it, to be honest.

Will try to have a bit of a dig tomorrow morning, unless you beat me to it

@softquantum
Copy link
Contributor Author

Will try to do it before ;)

@zerolab zerolab merged commit 99d93e5 into wagtail:main Dec 20, 2023
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants