-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Translation Object Duplicates #756
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 92.63% 92.58% -0.05%
==========================================
Files 47 47
Lines 4057 4059 +2
Branches 601 602 +1
==========================================
Hits 3758 3758
- Misses 176 177 +1
- Partials 123 124 +1 ☔ View full report in Codecov by Sentry. |
This is a good start @ACK1D. Thank you for correcting the typos too. Could you please add some tests? I'd add a new |
@zerolab thanks a bunch for the detailed info. Can you check this out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking note, but this is great work, thank you!
Co-authored-by: Dan Braghiș <dan@zerolab.org>
Prevent the creation of duplicate Translation objects with the same source and target locale. Replaced the explicit check for existing translations with the use of the
get_or_create
method, ensuring atomicity and avoiding potential duplicates. Fix #749