-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send campaign #37
Send campaign #37
Conversation
@@ -45,9 +46,29 @@ def url(self) -> str: | |||
else: | |||
return f"{base_url}/campaigns/edit?id={self.web_id}" | |||
|
|||
def get_report(self) -> "dict[str, Any]": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type here is intentionally vague, so that it's easy to override this method, and the {% block campaign_status %}
block, to show more (or different) information in the report.
I started to test the branch on my local environment, and overall it seems to work pretty well 👍 I really like the spinner that is started just before the form is submitted, as it gives a much better user experience to the editor while the communication with Mailchimp takes place 🙂 I have 2 questions, that are not related to that specific PR but it seems that we're getting closer to being able to use that package for real now so I thought it could be worth testing a bit more thoroughly:
Screenshot of Merge Tags displayed as italic text in the received email: |
Thank you! Yeah, I think we have the opportunity to provide a nice user experience, and it's nice to have a slick interface 🙂
Huh, you raise a good point, I hadn't realised this. I've opened an issue: #39.
No, I don't think so. Since this was introduced in a former PR, and I'd rather get this one merged, I've opened another issue: #40. |
Fixes #24.
Fixes #25.