Refactor ModelAdmin breadcrumbs regression tests to be more flexible #8547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix test regressions in
stable/3.0.x
by making the ModelAdmin breadcrumb tests more flexible. We’ve changed those templates in #8491, and only cherry-picked the most fundamental changes tostable/3.0.x
, which is causing test failures for that branch only.There are 3 "breadcrumbs position in ModelAdmin" test cases, 2 were failing. I’ve updated those two to work the same as the one that was still passing. I’ve also updated the three tests to check the presence of the
nav
landmark region, rather than theul
, as that’s more semantically what should denote where the breadcrumbs are.I find the value of this "position" test a bit dubious compared to just testing whether the breadcrumbs are present or not. Hopefully something we could revisit as part of #8539.