Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bdpt] C++ versions differs from Rust version #127

Closed
wahn opened this issue Sep 25, 2020 · 4 comments
Closed

[bdpt] C++ versions differs from Rust version #127

wahn opened this issue Sep 25, 2020 · 4 comments
Assignees
Labels

Comments

@wahn
Copy link
Owner

wahn commented Sep 25, 2020

v0.7.3 still renders the same as the C++ version. Somewhere after that a bug was introduced. Needs debugging.

@wahn wahn added the bug label Sep 25, 2020
@wahn wahn self-assigned this Sep 25, 2020
@wahn
Copy link
Owner Author

wahn commented Sep 25, 2020

$ git describe --tags
v0.7.3
$ imf_diff pbrt.png pbrt_cpp.png 
pbrt.png pbrt_cpp.png: no differences.
== "pbrt.png" and "pbrt_cpp.png" are identical

@wahn
Copy link
Owner Author

wahn commented Sep 25, 2020

$ git checkout v0.8.0
$ make
$ ./target/release/rs_pbrt speed_test.pbrt
$ imf_diff pbrt.png pbrt_cpp.png
differing pixels:	 80.053% (50033 of 62500)
average difference:	  4.646%
maximum difference:	 14.728%
Summary: Many pixels differ.
== "pbrt.png" and "pbrt_cpp.png" are different

@wahn
Copy link
Owner Author

wahn commented Sep 26, 2020

Commit b7a3e3d seems to introduce the bug ...

@wahn
Copy link
Owner Author

wahn commented Sep 28, 2020

$ git describe --tags
v0.8.2-62-gf2cd4ae
$ imf_diff pbrt_cpp.png pbrt.png 
pbrt_cpp.png pbrt.png: no differences.
== "pbrt_cpp.png" and "pbrt.png" are identical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant