Fixed panic on diffparser when first line is invalid #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a panic that is not caught on the latest release of diffparser that is not caught by
error
handling.I have introduced in my tool, and thought to share the fix with everyone, and hopefully to have it merged soon.
How to produce the panic?
The
diff_raw
is missingdiff --git a/file.txt b/file.txt
Best Regards,
Mazin