Handle diffs containing deleted symlinks (fixes a go panic) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this regex didn't match diffs for deleted symlinks: https://github.com/waigani/diffparser/blob/master/diffparser.go#L165 This led to an error here: https://github.com/waigani/diffparser/blob/master/diffparser.go#L167 If the Regex finds no matches, the code tried to index into an array of length 0.
|
Hello @waigani and thanks for making this library! If I can be of any particular help in getting this merged, please let me know. You should be able to verify it works by running |
|
I noticed another case where a similar diff occurs. If you just add / remove a newline from the end of the file, it also results in a diff that's missing the first length param Example: diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index 6b2e78d..7272c3f 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -1 +1 @@
-* nathan.leiby@clever.com
+* nathan.leiby@clever.com
\ No newline at end of file |
This was referenced Jan 8, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this regex didn't match diffs for deleted symlinks: https://github.com/waigani/diffparser/blob/master/diffparser.go#L165
This led to a panic here: https://github.com/waigani/diffparser/blob/master/diffparser.go#L167
If the Regex finds no matches, the code tried to index into an array of length 0.