Macos: Cmd+Q, can not quit app

[daodao97]

Description

First, Thanks very much wails team,

I build my app with wails2, github url is EasyClash

When app is open, press Cmd + Q, can not quit app.

To Reproduce

1. open EasyClash
2. Press Cmd+Q

Expected behaviour

Quit App when press Cmd+Q

Screenshots

No response

Attempted Fixes

No response

System Details

Wails CLI v2.0.0-beta.36


Scanning system - Please wait (this may take a long time)...Done.

System
------
OS:		MacOS
Version: 	11.6
ID:		199506
Go Version:	go1.17.2
Platform:	darwin
Architecture:	amd64

Wails
------
Version: 	v2.0.0-beta.36

Dependency			Package Name	Status		Version
----------			------------	------		-------
xcode command line tools 	N/A		Installed	2384
npm 				N/A		Installed	8.0.0
*upx 				N/A		Installed	upx 3.96
*nsis 				N/A		Available

Additional context

No response

[daodao97]

Can reproduce in the template repo wails-vue3-tpl

[leaanthony]

Did you bind it?

[daodao97]

not did, if i write code like this, Cmd+Q can quit

    myMenu := menu.NewMenuFromItems(
        menu.SubMenu("File", menu.NewMenuFromItems(
            menu.Text("&Open", keys.CmdOrCtrl("o"), openFile),
            menu.Separator(),
            menu.Text("Quit", keys.CmdOrCtrl("q"), func(_ *menu.CallbackData) {
                runtime.Quit()
            }),
        )),
    )

    runtime.MenuSetApplicationMenu(myMenu)

but Cmd+C, Cmd+V will not working in app input html tag.

[leaanthony]

On Mac, you have to do that yourself, it's not a systemwide feature. There's an edit menu role that you can use.

[daodao97]

in the source code pkg/options:Line 115

	switch runtime.GOOS {
	case "darwin":
		if appoptions.Menu == nil {
			appoptions.Menu = defaultMacMenu
		}
	}

var defaultMacMenu = menu.NewMenuFromItems(
	menu.AppMenu(),
	menu.EditMenu(),
)

if i set my custom enum, then must add menu.EditMenu() in my MenuFromItems, code example

	myMenu := menu.NewMenuFromItems(
		menu.SubMenu("File", menu.NewMenuFromItems(
			menu.Separator(),
			menu.Text("Quit", keys.CmdOrCtrl("q"), func(_ *menu.CallbackData) {
				runtime.Quit(context.Background())
			}),
		)),
		menu.EditMenu(),
	)

then, Cmd+A, Cmd+C, Cmd+V, Cmd+X is working.

maybe, we should tips it in docs.

[leaanthony]

Happy to accept a PR!!!

[daodao97]

PR @ pull/1423