Updated windows window/frontend to fix issue with html select positioning

[MikeSchaap]

Fixes #1081

Need to wait for the following PR (leaanthony/go-webview2#5) to merge so go-webview2 exposes the NotifyParentWindowPositionChanged() method.

Was not sure how to correctly expose the chromium object to the window object. Do you agree with the proposed fix? Doesn't feel really solid imo

Note: First time creating a public Pull Request, so if I can improve certain parts, please let me know :)

[leaanthony]

I would suggest having the notify function in the Window struct rather than options, as that's user options. In frontend Run, you can set the notify callback directly on the window struct after setting up chromium

[MikeSchaap]

I moved the notifyParentWindowPositionChanged method to the Window struct and set the value in the Run method of Frontend. I was getting a nil pointer on the WndProc because it was called before the notifyParentWindowPositionChanged method was set. I moved the winc.RegMsgHandler(w) method call from the NewWindow method to the Window.Run method to make sure notifyParentWindowPositionChanged method was set before it was being used. Do you have any idea if this might interfere with anything else? From my (short) testing, everything seemed to still work.

[MikeSchaap]

Also, I guess we still have to wait for a new tag on the go-webview2 repo before we can update the version in go.mod right?

[leaanthony]

I think this is almost ready to go 👍

[leaanthony]

Also need to resolve conflicts

[MikeSchaap]

Oh no, i'm pretty sure i messed up... I shouldn't work on sunday i guess.. Trying to figure out how to 'restore' this PR

[MikeSchaap]

Looks like I managed to revert the messup. Also moved the winc.RegMsgHandler(result) back to it's original position and resolved the conflicts. I believe we should be good to go now

[leaanthony]

Also, I guess we still have to wait for a new tag on the go-webview2 repo before we can update the version in go.mod right?

Nah, just update the dependency to use latest commit. I usually specify this like go get .....@ab2c3b2
Do you need to update go.mod + go.sum in this PR?

[stffabi]

Also, I guess we still have to wait for a new tag on the go-webview2 repo before we can update the version in go.mod right?

Nah, just update the dependency to use latest commit. I usually specify this like go get .....@ab2c3b2 Do you need to update go.mod + go.sum in this PR?

PR #1105 already bumped the go-webview2 dependency and that PR has been merged. Therefore we could merge this PR without needing to bump it.
Should we squash the commits before merging?

[leaanthony]

LGTM!

[MikeSchaap]

Cheers 🍾

[leaanthony]

Congrats on your first PR!