Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lit-ts template #1494

Merged
merged 4 commits into from Jun 27, 2022
Merged

Conversation

Orijhins
Copy link
Contributor

This pull fixes a bug where a newly generated lit-ts template would have incorrect syntax in the fronted/src/my-element.ts file

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. The template is the default vite template. Do you know if it's an issue there too?

Thanks for raising this 🙏

@leaanthony
Copy link
Member

Rather than update the template itself, could you add the file under the generate directory so it isn't over written next time we regenerate? Thanks!

@Orijhins
Copy link
Contributor Author

I didn't see any problem with Vite so far. If they had this same problem in their template, it seems to have been fixed:
https://stackblitz.com/edit/vitejs-vite-vmnt6c?file=src%2Fmy-element.ts&terminal=dev

@leaanthony
Copy link
Member

It may be a recent fix. I'll check why the generated code isn't as expected 👍

@Orijhins
Copy link
Contributor Author

I fixed it with the latest commit, but it is indeed interesting

@leaanthony leaanthony merged commit b2cec41 into wailsapp:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants