Fix lit-ts template #1494
Merged
Fix lit-ts template #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaanthony
reviewed
Jun 25, 2022
|
Rather than update the template itself, could you add the file under the generate directory so it isn't over written next time we regenerate? Thanks! |
|
I didn't see any problem with Vite so far. If they had this same problem in their template, it seems to have been fixed: |
|
It may be a recent fix. I'll check why the generated code isn't as expected 👍 |
|
I fixed it with the latest commit, but it is indeed interesting |
leaanthony
reviewed
Jun 27, 2022
v2/cmd/wails/internal/commands/initialise/templates/templates/lit-ts/frontend/src/my-element.ts
Outdated
Show resolved
Hide resolved
...ils/internal/commands/initialise/templates/generate/assets/lit-ts/frontend/src/my-element.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull fixes a bug where a newly generated lit-ts template would have incorrect syntax in the fronted/src/my-element.ts file