Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OnBeforeClose code for Mac #1558

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Conversation

leaanthony
Copy link
Member

There was a potential to lock the main thread in the OnBeforeClose method. This fixes that.

Fixes #1552

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8fae1a1
Status:⚡️  Build in progress...

View logs

@leaanthony leaanthony merged commit 69016c6 into master Jul 14, 2022
@leaanthony leaanthony deleted the bugfix/macos_onbeforeclose branch July 14, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V2][Mac] App will not responding when using MessageDialog in onBeforeClose
1 participant