Add -s support for wails dev#1632
Conversation
|
Just crossed my mind, couldn't we skip building the frontend in dev mode if we use an external dev server? Since #1615 we install all dependencies for the frontend/devserver outside of the build. So we could always skip building the frontend in that case, since we only proxy to the external dev server. |
|
That's a valid point. I think we should keep this flag for when someone doesn't use a Dev server but we should skip when they do 👍 |
|
Yeah, absolutely. |
|
@stffabi - looks like you added this scenario in March: https://github.com/wailsapp/wails/blob/master/v2/cmd/wails/internal/commands/dev/dev.go#L689-L691 If you're happy this covers that scenario then I think this is ready for merging 👍 |
That will only skip triggering a reload of the frontend when frontend files get changed. It won't prevent building the frontend when a rebuild due to changed go files is triggered. I think the following should do what we want: - IgnoreFrontend: false,
+ IgnoreFrontend: flags.skipFrontend || flags.frontendDevServerURL != "", |
|
Perfect! I'll get that in tonight. |
Fixes #1623