Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add Nodejs version in wails doctor #2546

Merged
merged 3 commits into from
Apr 11, 2023
Merged

feat(cli): add Nodejs version in wails doctor #2546

merged 3 commits into from
Apr 11, 2023

Conversation

misitebao
Copy link
Contributor

@misitebao misitebao commented Mar 31, 2023

  • Add Nodejs version in wails doctor
  • Test
    • Windows
    • Mac
    • Linux
  • Update changelog

Resolve: #2537
Preview:

$ wails doctor
DEB | Using go webview2loader
Wails CLI v2.4.1

Scanning system - Please wait (this may take a long time)...Done.

# System

OS           | Windows 10 Pro
Version      | 2009 (Build: 19045)
ID           | 22H2
Go Version   | go1.20
Platform     | windows
Architecture | amd64

# Wails

Version  | v2.4.1
Revision | 2a22933220a57eb34b461fa97a2b53026859c736
Modified | true

# Dependencies

Dependency | Package Name | Status    | Version
WebView2   | N/A          | Installed | 111.0.1661.54
Nodejs     | N/A          | Installed | 18.14.2
npm        | N/A          | Installed | 9.5.1
*upx       | N/A          | Available |
*nsis      | N/A          | Available |
* - Optional Dependency

# Diagnosis

Your system is ready for Wails development!
Optional package(s) installation details:
  - upx : Available at https://upx.github.io/
  - nsis : More info at https://wails.io/docs/guides/windows-installer/

 ♥   If Wails is useful to you or your company, please consider sponsoring the project:
https://github.com/sponsors/leaanthony

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wails-v3-docs ❌ Failed (Inspect) Apr 1, 2023 10:58am

@leaanthony
Copy link
Member

This is great! Which platforms did you test on?

@misitebao
Copy link
Contributor Author

This is great! Which platforms did you test on?

Only tested on Windows.

@leaanthony
Copy link
Member

Checked on macOS. Pushed a small check. Just need this tested on linux

@leaanthony
Copy link
Member

I just checked and linux's output is identical so I'm happy it works. Could you update the changelog? 👍

@misitebao misitebao added Enhancement New feature or request cli labels Apr 3, 2023
@misitebao misitebao added this to the v2.4.0 milestone Apr 6, 2023
@misitebao
Copy link
Contributor Author

Hi, @leaanthony

Does this PR still need improvement?

@leaanthony leaanthony merged commit 5e3c736 into wailsapp:master Apr 11, 2023
@misitebao misitebao deleted the feature/2537-add-node-version branch April 11, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show node version in wails doctor
2 participants