Update zypper.go (opensuse-tumbleweed) #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaanthony
reviewed
Apr 14, 2023
| @@ -60,7 +62,9 @@ func (z *Zypper) PackageInstalled(pkg *Package) (bool, error) { | |||
| if pkg.SystemPackage == false { | |||
| return false, nil | |||
| } | |||
| stdout, _, err := shell.RunCommand(".", "zypper", "info", pkg.Name) | |||
| var env []string | |||
| env = shell.SetEnv(env, "LANGUAGE", "en_US.utf-8") | |||
There was a problem hiding this comment.
Do we know this isn't going to break non US English installations?
There was a problem hiding this comment.
Yes, my OS was Chinese, if we don't set LANGUAGE env variable here, the zypper info pkgName command will return result in Chinese, so wails doctor will nott work properly here.
|
Please update the changelog in |
|
OK, updated. |
leaanthony
approved these changes
Apr 14, 2023
Add package(webkit2gtk3-soup2-devel) for `libwebkit`. Change environment variable before running command to query information of the package.
leaanthony
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libwebkit.pkg-config.