-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add print functionality to v2 #2822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Can you please add an update to the changelog in the website/static dir.
@aangelisc - Please could you add an entry to the changelog located at |
Sorry @leaanthony I will do this week! Haven't had the chance to update my PR |
@leaanthony CHANGELOG updated! 😊 Sorry it took so long |
Hey @leaanthony, this should be ready to merge now 😊 |
Thanks @aangelisc - I think we also need to update the runtime documentation too 😅 |
@leaanthony updated the runtime docs too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for your work on this 🙏
This is a backport of the print functionality that was created for v3 in this commit.
A couple notes before this is approved for merging:
Objective-C is not a language I'm familiar with so I'm not 100% on this despite the fact that I've basically just copy-pasted most of this with some minor edits 😊