Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add print functionality to v2 #2822

Merged
merged 7 commits into from
Sep 5, 2023
Merged

Conversation

aangelisc
Copy link
Contributor

This is a backport of the print functionality that was created for v3 in this commit.

A couple notes before this is approved for merging:

  • Have only tested this on MacOS not Windows or Linux.
  • I think it's definitely prudent to add the configuration to the print function and leave sensible defaults if the developer/user provides no config.
  • I've removed the margins that were added in the v3 version. I think it's more sensible to have no default margin but open to suggestions.

Objective-C is not a language I'm familiar with so I'm not 100% on this despite the fact that I've basically just copy-pasted most of this with some minor edits 😊

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Can you please add an update to the changelog in the website/static dir.

@leaanthony
Copy link
Member

@aangelisc - Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

@aangelisc
Copy link
Contributor Author

Sorry @leaanthony I will do this week! Haven't had the chance to update my PR

@aangelisc
Copy link
Contributor Author

@leaanthony CHANGELOG updated! 😊 Sorry it took so long

@aangelisc
Copy link
Contributor Author

Hey @leaanthony, this should be ready to merge now 😊

@leaanthony
Copy link
Member

Thanks @aangelisc - I think we also need to update the runtime documentation too 😅

@aangelisc
Copy link
Contributor Author

@leaanthony updated the runtime docs too!

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for your work on this 🙏

@leaanthony leaanthony merged commit 886bcc7 into wailsapp:master Sep 5, 2023
8 of 9 checks passed
@aangelisc aangelisc deleted the v2-print branch February 1, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants