Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appimage file sourcing #3306

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Fix appimage file sourcing #3306

merged 1 commit into from
Mar 17, 2024

Conversation

atterpac
Copy link
Contributor

Description

Locating the files to bundle webkit into an appimage was hard coded to /usr/lib which is not the case everytime.
Fixed to search /usr/ directory entirely as well as report back which necessary files are missing

Fixes # (issue)
Mentioned in Discord

Type of change

Please delete options that are not relevant.

  • [X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

# Build Environment
Wails CLI      | v3.0.0-alpha.3
Go Version     | go1.22.0
Revision       | f38532bcf5be446ebbf2b68498bb4521975b10fc
Modified       | true
-buildmode     | exe
-compiler      | gc
CGO_CFLAGS     |
CGO_CPPFLAGS   |
CGO_CXXFLAGS   |
CGO_ENABLED    | 1
CGO_LDFLAGS    |
DefaultGODEBUG | httplaxcontentlength=1,httpmuxgo121=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
GOAMD64        | v1
GOARCH         | amd64
GOOS           | linux
vcs            | git
vcs.modified   | true
vcs.revision   | f38532bcf5be446ebbf2b68498bb4521975b10fc
vcs.time       | 2024-03-08T07:06:14Z

# System
Name         | Ubuntu
Version      | 22.04
ID           | ubuntu
Branding     | 22.04.3 LTS (Jammy Jellyfish)
Platform     | linux
Architecture | amd64
gcc          | 12.9ubuntu3
libgtk-3     | 3.24.33-1ubuntu2
libwebkit    | 2.42.5-0ubuntu0.22.04.2
npm          | 8.5.1~ds-1
pkg-config   | 0.29.2-1ubuntu3
CPU          | AMD Ryzen 7 3700X 8-Core Processor
GPU 1        | Unknown
Memory       | 12GB

Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Add findGTKFiles to source webkit files for appimage generation

s
@leaanthony leaanthony merged commit ec2ce3f into wailsapp:v3-alpha Mar 17, 2024
5 of 8 checks passed
@leaanthony
Copy link
Member

Thanks @atterpac! Can you please update the changelog too 🙏

atterpac added a commit to atterpac/wails that referenced this pull request Apr 7, 2024
Add findGTKFiles to source webkit files for appimage generation

s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants