Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update expected baseline #2

Merged
merged 4 commits into from
Jul 14, 2023
Merged

update expected baseline #2

merged 4 commits into from
Jul 14, 2023

Conversation

wakamex
Copy link
Owner

@wakamex wakamex commented Jul 14, 2023

looking at the differences between modern Erigon and the openethereum outputs from 2020 which comprised the existing 'expected' baseline, we can rule out the following benign differences, and update our expected baseline to match modern Erigon.

  • changed gas value
  • remove null result of transactionHash and transactionPosition
  • improved error message

@wakamex wakamex merged commit e79bf83 into main Jul 14, 2023
@wakamex wakamex deleted the update_tests branch July 14, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant