Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser activity filter #234

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Add browser activity filter #234

merged 5 commits into from
Mar 25, 2024

Conversation

starbugs
Copy link
Contributor

@starbugs starbugs commented Mar 21, 2024

I took the liberty to redesign the Settings window a bit:
Screenshot 2024-03-21 at 13 33 32
The whitelist also supports the @@ syntax.

Closes #196

@alanhamlett
Copy link
Member

Let's rename to allow and deny lists, like: all except denied sites

@alanhamlett
Copy link
Member

I don't like the @@ syntax, let's use structured UI and data?

@starbugs
Copy link
Contributor Author

I don't like the @@ syntax, let's use structured UI and data?

Not sure I understand exactly what you mean...

@starbugs
Copy link
Contributor Author

Let's rename to allow and deny lists, like: all except denied sites

This is renamed now.

Let me know what to do about the @@ syntax then I will finalize this PR.

@alanhamlett
Copy link
Member

For @@, we should build into the UI the ability to assign a project to a domain. We want to build a UI similar to custom rules on the website, where we have a button Add new project rule that adds a new form row with two input fields url regex and project. When the full url matches a regex, we use the corresponding project name.

For now, let's just not support the @@ syntax and build the Custom Project Regex feature in a future PR.

@alanhamlett
Copy link
Member

Also, we need a setting to toggle sending full url or domain-only for browsing activity.

@alanhamlett
Copy link
Member

Actually, let's make the allow/deny list regexes which can match the full url.

@starbugs starbugs force-pushed the feature/browser-activity-filter branch from 7d475c0 to f297e8d Compare March 25, 2024 10:33
@starbugs
Copy link
Contributor Author

starbugs commented Mar 25, 2024

Actually, let's make the allow/deny list regexes which can match the full url.

I implemented that and removed the @@ syntax.

Do you want to add something to the remarks below the text view?

@alanhamlett
Copy link
Member

Actually, let's make the allow/deny list regexes which can match the full url.

I implemented that and removed the @@ syntax.

Thank you! That's so much better than @@ syntax.

Copy link
Member

@alanhamlett alanhamlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Devs have waited for a long time for this feature... you've made them very happy!

@starbugs starbugs merged commit 1ded43b into main Mar 25, 2024
6 checks passed
@starbugs starbugs deleted the feature/browser-activity-filter branch March 25, 2024 10:45
@alanhamlett alanhamlett mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to filter browsing activity by url
2 participants