Support reading api-key from vault command #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhamlett
reviewed
Nov 24, 2022
plugin/wakatime.vim
Outdated
| @@ -6,7 +6,7 @@ | |||
| " Website: https://wakatime.com/ | |||
| " ============================================================================ | |||
|
|
|||
| let s:VERSION = '9.0.1' | |||
| let s:VERSION = '9.1.0' | |||
There was a problem hiding this comment.
Let's not mix version bumps with code changes.
There was a problem hiding this comment.
I did it to test locally and forgot to rollback :(
alanhamlett
reviewed
Nov 24, 2022
plugin/wakatime.vim
Outdated
|
|
||
| if !found_api_key | ||
| let vault_cmd = s:GetIniSetting('settings', 'api_key_vault_cmd') | ||
| if vault_cmd != '' |
There was a problem hiding this comment.
There was a problem hiding this comment.
Is there a guideline to use empty function? There are other lines of code that's not using it, like
if s:GetIniSetting('settings', 'api_key') != '' || s:GetIniSetting('settings', 'apikey') != ''
There was a problem hiding this comment.
That's just legacy code, we can change it to also use empty later.
alanhamlett
approved these changes
Nov 24, 2022
alanhamlett
requested changes
Nov 24, 2022
gandarez
force-pushed
the
feature/api-key-vault-cmd
branch
from
b76e20c
to
8db1787
Compare
alanhamlett
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes vim to also read from vault command if present.
wakatime/wakatime-cli#783 (comment)