Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add files via upload #8

wants to merge 3 commits into from

Conversation

UweOhse
Copy link

@UweOhse UweOhse commented Apr 28, 2019

This patch does two things:

  1. add a few more metrics from nodes/.../rrddata (iowait possibly the most interesting).
  2. add --one-shot option to aid development

1. add a few more metrics from nodes/.../rrddata
2. add --one-shot option to aid development.
newestIdx := 0
var newestVal json.Number
for idx, r := range rList {
if (r.Time>newestVal) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use sort?

LoadAvg json.Number `json:"loadavg"`
NetIn json.Number `json:"netin"`
NetOut json.Number `json:"netout"`
SwapUsed json.Number `json:"swapused"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go fmt?

DiskRead json.Number `json:"diskread"`
DiskWrite json.Number `json:"diskwrite"`
RamTotal json.Number `json:"maxmem"`
RamFree json.Number `json:"mem"`
RamUsed json.Number `json:"mem"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also update the Readme file with metrics name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants