Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#438) ๋„๋ฉ”์ธ ๋ชจ๋“ˆ ๋ถ„๋ฆฌ 6์ฐจ #467

Merged
merged 1 commit into from
Mar 10, 2024
Merged

๐Ÿ”€ :: (#438) ๋„๋ฉ”์ธ ๋ชจ๋“ˆ ๋ถ„๋ฆฌ 6์ฐจ #467

merged 1 commit into from
Mar 10, 2024

Conversation

KangTaeHoon
Copy link
Contributor

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋„๋ฉ”์ธ ๋ชจ๋“ˆ ๋ถ„๋ฆฌ 6์ฐจ
๋Œ€์ƒ: LikeDomain

Resolves: #438

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • LikeDomain ๋ชจ๋“ˆ ์ถ”๊ฐ€ ๋ฐ ๋””ํŽœ๋˜์‹œ ์„ค์ •
  • Service ๋ชจ๋“ˆ์˜ ์ฝ”๋“œ LikeDomain๋กœ ์ด์ „
  • ๋ ˆ๊ฑฐ์‹œ ์ œ๊ฑฐ
  • tuist graph ์—…๋ฐ์ดํŠธ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

image

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added โšก๏ธ Performance ์„ฑ๋Šฅ ๊ฐœ์„  2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง labels Mar 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon

baekteun
baekteun approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KangTaeHoon KangTaeHoon merged commit a2c162a into develop Mar 10, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the feature/438-module-domain-6round branch March 10, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@baekteun baekteun baekteun approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โšก๏ธ Performance ์„ฑ๋Šฅ ๊ฐœ์„  โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋„๋ฉ”์ธ ๋ชจ๋“ˆ ๋ถ„๋ฆฌ 6์ฐจ
3 participants
@KangTaeHoon @yongbeomkwak @baekteun