Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keystore implementation #70

Merged
merged 41 commits into from
Oct 14, 2023
Merged

feat: keystore implementation #70

merged 41 commits into from
Oct 14, 2023

Conversation

weboko
Copy link
Contributor

@weboko weboko commented Oct 3, 2023 •
edited
Loading

Addresses (1) in waku-org/js-waku#1600

  • add tests

rymnc
rymnc approved these changes Oct 5, 2023
View reviewed changes
Copy link

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, if we can have interop tests between nwaku and js-waku generated keystores it'd be awesome

weboko
weboko commented Oct 10, 2023
View reviewed changes
src/keystore/keystore.ts Outdated Show resolved Hide resolved
@weboko weboko marked this pull request as ready for review October 10, 2023 00:06
@weboko weboko mentioned this pull request Oct 10, 2023
Open
@weboko
Copy link
Contributor Author

weboko commented Oct 10, 2023

@rymnc added issue for that #71

@fryorcraken
Copy link
Contributor

LGTM in general, if we can have interop tests between nwaku and js-waku generated keystores it'd be awesome

#25

@weboko weboko merged commit 891ee34 into master Oct 14, 2023
4 of 5 checks passed
@weboko weboko deleted the weboko/keystore branch October 14, 2023 00:21
@weboko weboko mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weboko @fryorcraken @rymnc