Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release master #1237

Merged
merged 1 commit into from
Mar 16, 2023
Merged

chore: release master #1237

merged 1 commit into from
Mar 16, 2023

Conversation

fryorcraken
Copy link
Collaborator

@fryorcraken fryorcraken commented Mar 14, 2023

🤖 I have created a release beep boop

core: 0.0.11

0.0.11 (2023-03-16)

⚠ BREAKING CHANGES

  • add custom events to Relay and make observers private (#1213)
  • add exports map to @waku/utils (#1201)
  • enable encoding of meta field
  • expose pubsub topic in IDecodedMessage
  • update store.proto
  • update message.proto: payload and content topic are always defined
  • ConnectionManager and KeepAliveManager (#1135)
  • bump typescript
  • bump all prod dependencies
  • bump libp2p dependencies

Features

  • Add custom events to Relay and make observers private (#1213) (275b166)
  • Codec as a property of the protocol implementations (a5ff788)
  • ConnectionManager and KeepAliveManager (#1135) (24c24cc)
  • Enable encoding of meta field (bd983ea)
  • Export Decoder, Encoder and DecodedMessage types from root (da1b18d), closes #1010
  • Expose pubsub topic in IDecodedMessage (628ac50), closes #1208
  • relay: Validate waku message at gossip layer (9684737)

Bug Fixes

  • Add payload to relay ping messages to avoid poor relay peer scoring (560c393)
  • Prettier and cspell ignore CHANGELOG (#1235) (4d7b3e3)
  • Remove initialising peer-exchange while creating a node (#1158) (1b41569)

Miscellaneous Chores

  • Add exports map to @waku/utils (#1201) (a30b2bd)
  • Bump all prod dependencies (88cc76d)
  • Bump libp2p dependencies (803ae7b)
  • Bump typescript (12d86e6)
  • Update message.proto: payload and content topic are always defined (5cf8ed2)
  • Update store.proto (967e6ff)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @waku/interfaces bumped from * to 0.0.8
      • @waku/proto bumped from * to 0.0.3
      • @waku/utils bumped from * to 0.0.2
create: 0.0.7

0.0.7 (2023-03-16)

⚠ BREAKING CHANGES

  • bump typescript
  • bump libp2p dependencies

Features

  • DNS discovery as default bootstrap discovery (#1114) (11819fc)

Bug Fixes

  • Prettier and cspell ignore CHANGELOG (#1235) (4d7b3e3)
  • Remove initialising peer-exchange while creating a node (#1158) (1b41569)

Miscellaneous Chores

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @waku/core bumped from * to 0.0.11
      • @waku/dns-discovery bumped from * to 0.0.6
      • @waku/peer-exchange bumped from * to 0.0.4
    • devDependencies
      • @waku/interfaces bumped from * to 0.0.8
dns-discovery: 0.0.6

0.0.6 (2023-03-16)

⚠ BREAKING CHANGES

  • add exports map to @waku/utils (#1201)
  • directly convert from ENR to PeerInfo, remove unneeded utility
  • extract decoder code
  • bump typescript
  • bump libp2p dependencies

Features

Bug Fixes

  • dns-discovery/peer-exchange: Check if peer is already tagged (952aadd)
  • Prettier and cspell ignore CHANGELOG (#1235) (4d7b3e3)

Miscellaneous Chores

  • Add exports map to @waku/utils (#1201) (a30b2bd)
  • Bump libp2p dependencies (803ae7b)
  • Bump typescript (12d86e6)
  • Directly convert from ENR to PeerInfo, remove unneeded utility (6dbcde0)
  • Extract decoder code (130c49b)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @waku/enr bumped from * to 0.0.6
      • @waku/utils bumped from * to 0.0.2
    • devDependencies
      • @waku/interfaces bumped from * to 0.0.8
enr: 0.0.6

0.0.6 (2023-03-16)

⚠ BREAKING CHANGES

  • add exports map to @waku/utils (#1201)
  • directly convert from ENR to PeerInfo, remove unneeded utility
  • extract encoder code
  • extract decoder code
  • bump typescript
  • bump all prod dependencies
  • bump libp2p dependencies

Bug Fixes

Miscellaneous Chores

  • Add exports map to @waku/utils (#1201) (a30b2bd)
  • Bump all prod dependencies (88cc76d)
  • Bump libp2p dependencies (803ae7b)
  • Bump typescript (12d86e6)
  • Directly convert from ENR to PeerInfo, remove unneeded utility (6dbcde0)
  • Extract decoder code (130c49b)
  • Extract encoder code (22ffcf5)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @waku/utils bumped from * to 0.0.2
    • devDependencies
      • @waku/interfaces bumped from * to 0.0.8
interfaces: 0.0.8

0.0.8 (2023-03-16)

⚠ BREAKING CHANGES

  • add custom events to Relay and make observers private (#1213)
  • enable encoding of meta field
  • expose pubsub topic in IDecodedMessage
  • directly convert from ENR to PeerInfo, remove unneeded utility
  • extract encoder code
  • update store.proto
  • update message.proto: payload and content topic are always defined
  • ConnectionManager and KeepAliveManager (#1135)
  • bump typescript
  • bump libp2p dependencies

Features

  • Add custom events to Relay and make observers private (#1213) (275b166)
  • Codec as a property of the protocol implementations (a5ff788)
  • ConnectionManager and KeepAliveManager (#1135) (24c24cc)
  • Enable encoding of meta field (bd983ea)
  • Expose pubsub topic in IDecodedMessage (628ac50), closes #1208

Bug Fixes

  • Prettier and cspell ignore CHANGELOG (#1235) (4d7b3e3)
  • Remove initialising peer-exchange while creating a node (#1158) (1b41569)

Miscellaneous Chores

  • Bump libp2p dependencies (803ae7b)
  • Bump typescript (12d86e6)
  • Directly convert from ENR to PeerInfo, remove unneeded utility (6dbcde0)
  • Extract encoder code (22ffcf5)
  • Update message.proto: payload and content topic are always defined (5cf8ed2)
  • Update store.proto (967e6ff)
message-encryption: 0.0.10

0.0.10 (2023-03-16)

⚠ BREAKING CHANGES

  • add exports map to @waku/utils (#1201)
  • enable encoding of meta field
  • expose pubsub topic in IDecodedMessage
  • update message.proto: payload and content topic are always defined
  • bump typescript

Features

  • Enable encoding of meta field (bd983ea)
  • Export Decoder, Encoder and DecodedMessage types from root (da1b18d), closes #1010
  • Expose pubsub topic in IDecodedMessage (628ac50), closes #1208

Bug Fixes

Miscellaneous Chores

  • Add exports map to @waku/utils (#1201) (a30b2bd)
  • Bump typescript (12d86e6)
  • Update message.proto: payload and content topic are always defined (5cf8ed2)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @waku/core bumped from * to 0.0.11
      • @waku/interfaces bumped from * to 0.0.8
      • @waku/proto bumped from * to 0.0.3
      • @waku/utils bumped from * to 0.0.2
peer-exchange: 0.0.4

0.0.4 (2023-03-16)

⚠ BREAKING CHANGES

  • directly convert from ENR to PeerInfo, remove unneeded utility
  • extract decoder code
  • bump typescript
  • bump all prod dependencies
  • bump libp2p dependencies

Features

  • Codec as a property of the protocol implementations (a5ff788)
  • DNS discovery as default bootstrap discovery (#1114) (11819fc)

Bug Fixes

  • dns-discovery/peer-exchange: Check if peer is already tagged (952aadd)
  • Prettier and cspell ignore CHANGELOG (#1235) (4d7b3e3)
  • Remove initialising peer-exchange while creating a node (#1158) (1b41569)

Miscellaneous Chores

  • Bump all prod dependencies (88cc76d)
  • Bump libp2p dependencies (803ae7b)
  • Bump typescript (12d86e6)
  • Directly convert from ENR to PeerInfo, remove unneeded utility (6dbcde0)
  • Extract decoder code (130c49b)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @waku/enr bumped from * to 0.0.6
      • @waku/proto bumped from * to 0.0.3
    • devDependencies
      • @waku/interfaces bumped from * to 0.0.8
proto: 0.0.3

0.0.3 (2023-03-16)

⚠ BREAKING CHANGES

  • enable encoding of meta field
  • update store.proto
  • update message.proto: payload and content topic are always defined
  • bump protons from 5.1.0 to 7.0.2
  • bump typescript
  • bump all prod dependencies

Features

  • Enable encoding of meta field (bd983ea)

Bug Fixes

Miscellaneous Chores

  • Bump all prod dependencies (88cc76d)
  • Bump protons from 5.1.0 to 7.0.2 (2f2d266)
  • Bump typescript (12d86e6)
  • Update message.proto: payload and content topic are always defined (5cf8ed2)
  • Update store.proto (967e6ff)
utils: 0.0.2

0.0.2 (2023-03-16)

⚠ BREAKING CHANGES

  • add exports map to @waku/utils (#1201)
  • directly convert from ENR to PeerInfo, remove unneeded utility
  • bump typescript
  • bump libp2p dependencies

Bug Fixes

Miscellaneous Chores

  • Add exports map to @waku/utils (#1201) (a30b2bd)
  • Bump libp2p dependencies (803ae7b)
  • Bump typescript (12d86e6)
  • Directly convert from ENR to PeerInfo, remove unneeded utility (6dbcde0)

This PR was generated with Release Please. See documentation.

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 116.74 KB (0%) 2.4 s (0%) 3.1 s (+10.94% 🔺) 5.5 s
Waku default setup 384.04 KB (0%) 7.7 s (0%) 5.9 s (+18.74% 🔺) 13.6 s
ECIES encryption 27.99 KB (0%) 560 ms (0%) 945 ms (-41.91% 🔽) 1.6 s
Symmetric encryption 27.99 KB (0%) 560 ms (0%) 1.5 s (-16.99% 🔽) 2.1 s
DNS discovery 108.07 KB (0%) 2.2 s (0%) 3.8 s (+13.16% 🔺) 6 s
Privacy preserving protocols 116.22 KB (0%) 2.4 s (0%) 2.7 s (+15.4% 🔺) 5 s
Light protocols 117.98 KB (0%) 2.4 s (0%) 2.3 s (-17.72% 🔽) 4.6 s
History retrieval protocols 118.06 KB (0%) 2.4 s (0%) 2.4 s (+8.72% 🔺) 4.8 s

@fryorcraken
Copy link
Collaborator Author

@weboko we know have issue around commit signature :/

@fryorcraken fryorcraken force-pushed the release-please--branches--master branch 2 times, most recently from 29b72d8 to 7ba922b Compare March 14, 2023 00:31
@fryorcraken
Copy link
Collaborator Author

fryorcraken commented Mar 14, 2023

Note that I could have created the PAT so it's in behalf of a bot. Not sure if it can help.

Also happy to somehow override/remove commit signing.

@fryorcraken fryorcraken force-pushed the release-please--branches--master branch from 7ba922b to 318bb6e Compare March 14, 2023 04:45
@weboko weboko self-requested a review March 14, 2023 09:10
@weboko
Copy link
Collaborator

weboko commented Mar 14, 2023

@fryorcraken now it's ready to be merged :)

@fryorcraken
Copy link
Collaborator Author

I can see "This branch is out-of-date with the base branch" warning.

@weboko
Copy link
Collaborator

weboko commented Mar 14, 2023

I can see "This branch is out-of-date with the base branch" warning.

I think it is because some changes were pushed into master and bot will update this PR at some point.

@fryorcraken fryorcraken force-pushed the release-please--branches--master branch from 318bb6e to 4038291 Compare March 15, 2023 20:54
@weboko
Copy link
Collaborator

weboko commented Mar 16, 2023

So it seems bot's commit is signed but because signature is not able to be verified check is not passing.
I can update CI to use GPG token but not sure if it is better that removing this hard rule.

https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#gpg-commit-signature-verification

@fryorcraken

@fryorcraken
Copy link
Collaborator Author

@weboko I have removed the hard rule. Let's get the release done please.
Let's track and issue to re-add the hard rule and to the manipulation above (I can handle it) for later.

@weboko
Copy link
Collaborator

weboko commented Mar 16, 2023

Created issue for it #1247

@weboko weboko merged commit b3546ae into master Mar 16, 2023
@weboko weboko deleted the release-please--branches--master branch March 16, 2023 19:29
@fryorcraken
Copy link
Collaborator Author

@fryorcraken
Copy link
Collaborator Author

@fryorcraken
Copy link
Collaborator Author

@fryorcraken
Copy link
Collaborator Author

🤖 Release is at https://github.com/waku-org/js-waku/releases/tag/enr-v0.0.6 🌻

@fryorcraken
Copy link
Collaborator Author

@fryorcraken
Copy link
Collaborator Author

@fryorcraken
Copy link
Collaborator Author

@fryorcraken
Copy link
Collaborator Author

@fryorcraken
Copy link
Collaborator Author

@weboko
Copy link
Collaborator

weboko commented Mar 20, 2023

@fryorcraken so what happened is that because 628ac50 mentions in the description #1208 - release-please recognised that it is resolves the issue linked by the PR. What is interesting that I don't see this behaviour being described anywhere and can only confirm it from the implementation.

For now I think we should stick to:

  • Refs for references, as it is mentioned in the spec;
  • Closes for issues that will be resolved, as mentioned in the code;

I will run some tests and update on what exactly happens.

Refs: https://github.com/googleapis/release-please/blob/21ed59a1db32c6b9593931519bfa3b1eb456a4a7/src/commit.ts#L175

@fryorcraken
Copy link
Collaborator Author

Thanks. I used Ref. Should I be using Refs to avoid closure or yet to be confirmed?

@weboko
Copy link
Collaborator

weboko commented Mar 20, 2023

For now yes, let's use Refs/Closes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

14/WAKU2-MESSAGE: Meta attribute and deterministic hashing API Improvements
2 participants