-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add waku store client module #1229
Conversation
Jenkins BuildsClick to see older builds (15)
|
d232fd7
to
8a76365
Compare
b3232b2
to
3d1ba3c
Compare
5e948f8
to
aa0937c
Compare
aa0937c
to
1c96807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
## Returns all the fetched messages, if error occurs, returns an error string | ||
|
||
# Make a copy of the query | ||
var req = query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, why do you need a copy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To update the cursor field, and keep the rest of the request intact. This part of the implementation has not been changed compared to the original protocol.nim
code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can't wait to not mount store protocol on store clients which ultimately allows us to greatly simplify config.
The waku store protocol is a request-response/client-server protocol. These changes decouple the client logic from the request-handling logic. So now it should be possible to do waku store history queries without mounting the store protocol handling/server part.
waku_store/client
moduleprotocol
client procedurestests/v2/test_waku_store_client.nim
)Remaining work:
wakunode2
/waku_node
.