Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): waku store rpc codec support optional fields #1393

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix(store): waku store rpc codec support optional fields #1393

merged 1 commit into from
Nov 17, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 17, 2022 •
edited

To follow the Waku store 2.0.0-beta4 protobuf definition:

  • Add support for the Option[x] type to the protobuf module at serialization time.
  • Remove the behavior of not serializing a value when it matches the type's default.
  • Update RPC types to match the protobuf definition. Use explicit Option[T] types when the field is optional.
  • Update API-RPC type mappings accordingly
  • Update the Waku store protocol and tests accordingly

This is a dependency of the Make waku_message.nim comply with the protobuf definition task.

@LNSD LNSD self-assigned this Nov 17, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 17, 2022 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 78a5cfc #1 2022-11-17 11:28:35 ~16 min linux 📦bin
✔️ 78a5cfc #1 2022-11-17 11:31:49 ~19 min macos 📦bin
✔️ 43b7f90 #2 2022-11-17 11:33:52 ~17 min linux 📦bin
✔️ 43b7f90 #2 2022-11-17 11:37:52 ~21 min macos 📦bin

rymnc
rymnc approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

waku/v2/protocol/waku_store/rpc.nim Show resolved Hide resolved
waku/v2/protocol/waku_store/rpc_codec.nim Show resolved Hide resolved
jm-clius
jm-clius approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LNSD LNSD merged commit f89e686 into master Nov 17, 2022
@LNSD LNSD deleted the fix-store-rpc-codec branch November 17, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@jm-clius jm-clius jm-clius approved these changes

@alrevuelta alrevuelta Awaiting requested review from alrevuelta

Assignees

@LNSD LNSD

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LNSD @status-im-auto @rymnc @jm-clius