chore(rln-relay): msg validation according to new circuit #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
changed the title
rymnc
force-pushed
the
fix-rln-message-validation
branch
from
1cdaeba
to
e526abb
Compare
rymnc
force-pushed
the
fix-rln-message-validation
branch
from
e526abb
to
f716ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1451
Functional changes in rln-relay:
epochas the key, we now use theexternal_nullifier, which is a combination of theepoch, and therlnIdentifier. This fixes the case when rln-relay was erroneously storing messages from multiple rln apps (linked to rlnIdentifiers) (which run on the same content topic/pubsub topic combination) which had the same epoch