test(waku-filter): Subscribe tests batch (1/4) #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroCabeza
changed the title
|
You can find the image built from this PR at Built from d7b3827 |
1 task
AlejandroCabeza
changed the title
Ivansete-status
approved these changes
Sep 19, 2023
AlejandroCabeza
force-pushed
the
test-waku-filter-subscribe
branch
from
b54e77a
to
e7bca65
Compare
AlejandroCabeza
changed the title
AlejandroCabeza
force-pushed
the
test-waku-filter-subscribe
branch
from
4f0326a
to
6605abf
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-subscribe
branch
from
6605abf
to
798c7f6
Compare
AlejandroCabeza
force-pushed
the
test-waku-filter-subscribe
branch
2 times, most recently
from
dc47a6f
to
76be3d1
Compare
NagyZoltanPeter
approved these changes
Oct 11, 2023
| await allFutures(wakuFilter.stop(), wakuFilterClient.stop(), | ||
| serverSwitch.stop(), clientSwitch.stop()) | ||
| discard | ||
| # asyncTest "simple subscribe and unsubscribe request": |
There was a problem hiding this comment.
I see prev comment from Ivan and the answer but am I missed something or why not simple remove it fully... let git remember if something is needed later/parallel?
There was a problem hiding this comment.
This was a mistake I made, it's removed in one of the following PRs.
AlejandroCabeza
force-pushed
the
test-waku-filter-subscribe
branch
from
76be3d1
to
c0f218b
Compare
* Implement waku filter client subscribe tests. * Remove legacy filter tests. * Fix constant for max criteria per subscription limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement first batch of subscribe tests for waku filter.
I commented the tests in
test_waku_filter.nimwhen I should've deleted them. The deletion has been added to the following PR.Changes