Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(waku-filter): Unsubscribe tests #2085

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

AlejandroCabeza
Copy link
Contributor

@AlejandroCabeza AlejandroCabeza commented Sep 26, 2023

Description

Implement unsubscribe tests for waku filter.

Changes

  • Implement waku filter unsubscribe tests.
  • Update waku filter protocol so it returns an error on wrong topic parameters.

Dependencies

#2057

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2085

Built from 9498b9d

@AlejandroCabeza AlejandroCabeza changed the base branch from master to test-waku-filter-subscribe-4 September 29, 2023 20:08
@AlejandroCabeza AlejandroCabeza force-pushed the test-waku-filter-unsubscribe branch 2 times, most recently from 94dbe39 to 6f23c52 Compare October 2, 2023 07:25
@AlejandroCabeza AlejandroCabeza self-assigned this Oct 9, 2023
@AlejandroCabeza AlejandroCabeza force-pushed the test-waku-filter-unsubscribe branch 2 times, most recently from 455b75a to bc9f23d Compare October 9, 2023 16:15
@AlejandroCabeza AlejandroCabeza marked this pull request as ready for review October 9, 2023 16:20
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome extensive testing! Thank you!
Only one suggestion for subscription exclusion use.

waku/waku_filter_v2/protocol.nim Show resolved Hide resolved
waku/waku_filter_v2/subscriptions.nim Show resolved Hide resolved
Base automatically changed from test-waku-filter-subscribe-4 to test-waku-filter-subscribe-3 October 12, 2023 18:57
Base automatically changed from test-waku-filter-subscribe-3 to test-waku-filter-subscribe-2 October 12, 2023 18:58
Base automatically changed from test-waku-filter-subscribe-2 to test-waku-filter-subscribe October 12, 2023 18:58
Base automatically changed from test-waku-filter-subscribe to master October 12, 2023 18:59
@AlejandroCabeza AlejandroCabeza requested review from vpavlin and removed request for Ivansete-status October 18, 2023 16:17
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!
Just added a little suggestion

waku/waku_filter_v2/subscriptions.nim Show resolved Hide resolved
@AlejandroCabeza AlejandroCabeza removed the request for review from vpavlin October 30, 2023 14:40
* Implement unsubscribe all and payload tests.
* Implement waku node filter Security and Privacy tests.
@AlejandroCabeza AlejandroCabeza merged commit 85265e6 into master Nov 15, 2023
6 of 8 checks passed
@AlejandroCabeza AlejandroCabeza deleted the test-waku-filter-unsubscribe branch November 15, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants