Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test_driver_postgres - enhance test coverage, multiple and single topic #2301

Merged

Conversation

Ivansete-status
Copy link
Collaborator

Description

This is to enhance the test coverage in postgres queries.
With this, we test the prepared statement query and the standard query (less optimal.)

This PR is motivated by this @alrevuelta's comment: #2296 (comment)

@Ivansete-status Ivansete-status self-assigned this Dec 15, 2023
Copy link

github-actions bot commented Dec 15, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2301

Built from e2ab7cd

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Ivansete-status Ivansete-status merged commit 8b37919 into master Dec 19, 2023
9 of 10 checks passed
@Ivansete-status Ivansete-status deleted the add-test-postgres-query-multiple-content-topic branch December 19, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants