chore: ip colocation is parameterizable. If set to 0, it is disabled #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "ip colocation" concept refers to the maximum allowed peers from the same IP address. We allow disable this limit when the node works behing a reverse proxy.
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
|
You can find the image built from this PR at Built from 8360201 |
Ivansete-status
requested review from
alrevuelta,
gabrielmer and
NagyZoltanPeter
gabrielmer
added
the
release-notes
gabrielmer
approved these changes
Jan 2, 2024
NagyZoltanPeter
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
LGTM! Great, I hope it also helps Filter subscriptions flood, tested by @chaitanyaprem.
Due that scenario will not work out if PeerManager can be configured to limit peers per IP.
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "ip colocation" concept refers to the maximum allowed peers from the same IP address. We allow disable this limit when the node works behing a reverse proxy.
How to test
ip-colocation-limitset to 0.ip-colocation-limitset to 2.ℹ️ in both cases remember to set
rest-admin = trueso that you can check the peers withcurl -X GET 127.0.0.1:8645/admin/v1/peers.Issue
closes #2306