Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Simplification of store legacy code #2931

Merged

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Jul 25, 2024

Description

While enhancing postgres queries I noticed that there is some conflict between legacy-store and future store.
This PR is aimed to mitigate those collisions by removing unnecessary code and giving the responsibility of partition management, and retention policy, only to the new-future store archive driver.

Copy link

github-actions bot commented Jul 25, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2931

Built from cafccff

@Ivansete-status Ivansete-status marked this pull request as ready for review July 25, 2024 19:47
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Apologies for the delay. For some reason I had already review it but forgot to mark it as approved 😶

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great, thank you.

@Ivansete-status Ivansete-status merged commit d4e8a0d into master Jul 30, 2024
9 of 11 checks passed
@Ivansete-status Ivansete-status deleted the avoid-collisions-between-legacy-and-current-archive branch July 30, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants