chore: lightpush better feedback if lightpush service node without peers #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 1c59682 |
Ivansete-status
requested review from
NagyZoltanPeter,
darshankabariya and
gabrielmer
NagyZoltanPeter
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Technically it is ok. I see the request from Status, while original agreement was that for this "legacy" lightpush that it is not considered as an error.
This will change with lightpush v2, under dev.
Consider this will break js-waku or at least needs them to adapt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Give better feedback in case the lightpush server node cannot relay messages to other peers
Issue
closes #2950