Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log parsing errors instead of failing #125

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Log parsing errors instead of failing #125

merged 4 commits into from
Dec 22, 2023

Conversation

khatchad
Copy link
Collaborator

  1. Split the class hierarchy construction front-end parsing error checking into two.
  2. Log parsing errors instead of throwing an exception.

@khatchad khatchad added the enhancement New feature or request label Dec 19, 2023
@khatchad khatchad enabled auto-merge (squash) December 19, 2023 15:20
msridhar
msridhar approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khatchad khatchad merged commit 1fd3e0e into wala:master Dec 22, 2023
1 check passed
@khatchad khatchad deleted the contrib_parsing_swallowing branch December 22, 2023 19:02
@khatchad khatchad mentioned this pull request Jul 12, 2024
Merged
khatchad added a commit that referenced this pull request Jul 12, 2024
@khatchad
Continue module parsing despite Jython parsing errors (#206)
cbd558e 
Let's see if we can still go through (similar to
[b3c28a8](#125)).

## Differences
1. Log a warning instead of throwing an exception, which stops the
module from processing. We are already doing this further up the stack
anyway:
https://github.com/wala/ML/blob/ef1cca799d7726bfc70cec7b838ebeec2516d5e4/com.ibm.wala.cast.python/source/com/ibm/wala/cast/python/client/PythonAnalysisEngine.java#L159-L166
2. Continue to convert to CAst despite the parsing error coming out of
Jython. This is a workaround for #205.
I think this should be OK (best-effort) as I don't see it contributing
to any soundness issues. And, from what I am seeing in the
[logs](https://github.com/ponder-lab/ML/actions/runs/9897547494/job/27342295209#step:12:32780),
the parsing errors are "mild."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msridhar msridhar msridhar approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khatchad @msridhar