Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bumb to 2.2.1 and added migrate command #48

Merged
merged 1 commit into from
Feb 1, 2017

Conversation

xsteadfastx
Copy link
Contributor

made the changes to get 2.2.1 running plus added a migrate command to
the entrypoint. documented it in the readme.

made the changes to get 2.2.1 running plus added a migrate command to
the entrypoint. documented it in the readme.
@opsydev
Copy link

opsydev commented Feb 1, 2017

Hey, I just tested this build with an existing install and it worked like a charm.

My setup:

Wallabag on docker
PostgreSQL on a separate machine (not containerized)

PS: I am super interested in seeing this merge as I want to use the Pinboard import feature in 2.2.0 :)

Copy link
Member

@nicosomb nicosomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems OK but I didn't try your image.

Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xsteadfastx
Copy link
Contributor Author

xsteadfastx commented Feb 1, 2017 via email

@bobberb
Copy link

bobberb commented Feb 1, 2017

@xsteadfastx I'm running your branch version-2.2.1 and cannot log in anymore.

Wallabag is provided the same/correct login info but login screen flashes

run command is

docker run --name wallabag-2.2.1r --link redis:redis -p 8885:80 -v /selfhosted/wallabag:/var/www/wallabag/data --restart=always -e "SYMFONY__ENV__DATABASE_DRIVER=pdo_mysql" -e "SYMFONY__ENV__DATABASE_HOST=172.17.0.1" -e "SYMFONY__ENV__DATABASE_PORT=3306" -e "SYMFONY__ENV__DATABASE_NAME=wallabag" -e "SYMFONY__ENV__DATABASE_USER=wally" -e "SYMFONY__ENV__DATABASE_PASSWORD=wally" -e "MYSQL_ROOT_PASSWORD=PASSWORD" josh/wallabag:2.2.1

just as I have with 2.1.5, however, log in screen flashes with no error outputting in the shell itself without -d

@xsteadfastx
Copy link
Contributor Author

xsteadfastx commented Feb 1, 2017

@bobberb did you migrate your database? thats important...

docker run --name wallabag-2.2.1r --link redis:redis -p 8885:80 -v /selfhosted/wallabag:/var/www/wallabag/data --restart=always -e "SYMFONY__ENV__DATABASE_DRIVER=pdo_mysql" -e "SYMFONY__ENV__DATABASE_HOST=172.17.0.1" -e "SYMFONY__ENV__DATABASE_PORT=3306" -e "SYMFONY__ENV__DATABASE_NAME=wallabag" -e "SYMFONY__ENV__DATABASE_USER=wally" -e "SYMFONY__ENV__DATABASE_PASSWORD=wally" -e "MYSQL_ROOT_PASSWORD=PASSWORD" josh/wallabag:2.2.1 migrate

should do it. if the image is built from that branch.

@bobberb
Copy link

bobberb commented Feb 1, 2017 via email

@xsteadfastx xsteadfastx merged commit 90265c1 into wallabag:master Feb 1, 2017
@xsteadfastx xsteadfastx deleted the version-2.2.1 branch February 1, 2017 10:14
@bobberb
Copy link

bobberb commented Feb 1, 2017

@xsteadfastx I definitely blew up the original database despite a clone and using the paramater -e"...DATABASE=wallabag22".

I wonder if I baked the original in to my image somewhere else. What is stored in the db, usernames only?

@xsteadfastx
Copy link
Contributor Author

@bobberb what original? migration doesnt work? you need the same parameters and put a migrate as command.

@bobberb
Copy link

bobberb commented Feb 1, 2017

before I ran your command I did a quick clone of db nammed wallabag to wallabag2 and subbed that in to the command. It definitely migrated successfully but I went back to test my original image and it's borked.

In the middle of a restore.

Maybe I should stick with sqlite :(

@tcitworld
Copy link
Member

We plan to drop SQLite. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants