Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NODE-5400 Node 5.0 Migration to wcli scripts #426

Merged
merged 1 commit into from
Aug 8, 2024
Merged

NODE-5400 Node 5.0 Migration to wcli scripts #426

merged 1 commit into from
Aug 8, 2024

Conversation

nedvna
Copy link
Collaborator

@nedvna nedvna commented Jun 14, 2024

No description provided.

@xDmitriev xDmitriev changed the title NODE-5400 Migration to wcli scripts NODE-5400 Node 5.0 Migration to wcli scripts Jun 18, 2024
Copy link
Member

@xDmitriev xDmitriev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove env var WALLARM_INGRESS_CONTROLLER_VERSION from init and corn containers and use WALLARM_COMPONENT_(NAME|VERSION) included in wallarm.credentials instead

https://gl.wallarm.com/wallarm-node/meganode/-/merge_requests/107#note_254559

@nedvna nedvna force-pushed the NODE-5400 branch 3 times, most recently from f346a01 to fd6f068 Compare June 20, 2024 13:39
@xDmitriev xDmitriev requested a review from qqshka June 26, 2024 09:24
@nedvna nedvna force-pushed the NODE-5400 branch 3 times, most recently from 6cb2737 to c95ce3e Compare July 1, 2024 15:31
@nedvna nedvna marked this pull request as ready for review July 1, 2024 15:32
@nedvna
Copy link
Collaborator Author

nedvna commented Aug 7, 2024

@qqshka are we alright with this one?

@nedvna nedvna merged commit 5d9b00c into main Aug 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants