Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LESS_TERMCAP standout color settings not working #114

Closed
joyguar opened this issue Dec 31, 2022 · 6 comments
Closed

LESS_TERMCAP standout color settings not working #114

joyguar opened this issue Dec 31, 2022 · 6 comments

Comments

@joyguar
Copy link

joyguar commented Dec 31, 2022

I just recently switched over to moar from less and it seems that moar doesn't respect the LESS_TERMCAP standout color settings as less does. My standout color settings are set by:

export LESS_TERMCAP_so=$'\E[01;38;2;187;194;207;48;2;56;122;167m'

This should produce highlighting with a light blue background and white foreground text. However, moar appears to be only inverting the color of the text and background for standout mode.

Per #14 moar should respect LESS_TERMCAP settings in the same way as less.

@walles
Copy link
Owner

walles commented Dec 31, 2022

I tried this with less, and the only thing that turned blue was the prompt at the bottom of the page.

Can you give an example / screenshot / repro case / something to demonstrate what you want to turn blue with this setting?

Since I don't use the LESS_TERMCAP settings myself I need some sort of test case to see that I'd be fixing the right thing.

@walles
Copy link
Owner

walles commented Dec 31, 2022

And search hits, I saw that now as well.

@joyguar
Copy link
Author

joyguar commented Dec 31, 2022

Yes, no problem. Here is a photo of what I see upon opening man pages.
screenshot02
Top is moar and bottom is less. You can see that the standout (highlighting) settings are applied to the bottom notification/banner in less but not moar.

Here is a photo of what I see upon searching:
screenshot01
Again, top is moar and bottom is less. You can see that search items are highlighted with colors according to termcap settings in less, but are simply inverting colors in moar.

@walles
Copy link
Owner

walles commented Dec 31, 2022

Cool, so it's search hits and the bottom status bar that should get the _so color.

walles added a commit that referenced this issue Dec 31, 2022
@walles walles closed this as completed in a7f2033 Dec 31, 2022
@walles
Copy link
Owner

walles commented Dec 31, 2022

Released 1.11.3 with this change in it. If you're on Homebrew, here's the release status: Homebrew/homebrew-core#119468

Please let me know how it works for you!

@joyguar
Copy link
Author

joyguar commented Jan 6, 2023

@walles It works perfectly! Thanks for making that update. I've now switched over to using moar entirely in place of less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants