Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new moar hung for few second while searching #209

Closed
ciscohack opened this issue May 11, 2024 · 7 comments
Closed

new moar hung for few second while searching #209

ciscohack opened this issue May 11, 2024 · 7 comments

Comments

@ciscohack
Copy link

In the latest moar, it seems the old search and freeze issue is back. while searching for any keyword CLI freeze for a few seconds.

moar version v1.23.13

@walles
Copy link
Owner

walles commented May 11, 2024

How big is your input?

I just tried with a 14MB file and searching was OK but not great.

@ciscohack
Copy link
Author

it has 5 lakh lines but this search freeze was fixed in old build when last time i reported if you remember..freeze is more evident when you accidently type wrong word not exist in file

@walles
Copy link
Owner

walles commented May 11, 2024

it has 5 lakh lines

I looked it up, this means five hundred thousand lines right?

@ciscohack
Copy link
Author

it has 5 lakh lines

I looked it up, this means five hundred thousand lines right?

yes correct!

walles added a commit that referenced this issue May 13, 2024
Should improve the performance situation reported here:
#209
@walles
Copy link
Owner

walles commented May 13, 2024

I'm not sure if this fixes it, but 1.23.14 should at least be less bad in this regard.

Please try it out and see what you think.

@ciscohack
Copy link
Author

@walles Thanks

@walles
Copy link
Owner

walles commented May 18, 2024

7b032b2 should make the search a lot faster for large files.

That version uses all available cores for searching, rather than just one.

@walles walles closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants