Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore newline vs space #43

Closed
walles opened this issue Aug 14, 2023 · 3 comments
Closed

Ignore newline vs space #43

walles opened this issue Aug 14, 2023 · 3 comments

Comments

@walles
Copy link
Owner

walles commented Aug 14, 2023

If a newline is replaced with a space character, or a space character is replaced with a newline, don't highlight this.

This is what happens when rewrapping text, and I think highlighting these changes doesn't help me understand what's going on.

Also consider what this would mean for indented text being rewrapped.

walles added a commit that referenced this issue Aug 14, 2023
Or the wanted lack thereof:
#43
@walles
Copy link
Owner Author

walles commented Aug 14, 2023

As long as distil/diffus#107 is still a thing we can't identify replacements (I think?), and this is not doable.

@walles
Copy link
Owner Author

walles commented Sep 22, 2024

Or, we could just unhighlight this in post processing.

@walles
Copy link
Owner Author

walles commented Oct 23, 2024

Done, out in 3.3.5!

@walles walles closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant