WA-419 Migration with the lower version was applied after higher migration #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanel
changed the title
andreigornostajev
suggested changes
Nov 14, 2017
migrator/migrator.go
Outdated
| func maxVersion(alreadyMigrated map[int64]bool) int64 { | ||
| result := int64(0) | ||
| for version, isMigrated := range alreadyMigrated { | ||
| if isMigrated && version > result { |
There was a problem hiding this comment.
What is this isMigrated for (it is always true)? Why we have map[int64]bool type at all? I think we should use map[int64]struct{} instead.
migrator/migrator.go
Outdated
| } | ||
|
|
||
| func chooseMigrations(files []file.File, alreadyMigrated map[int64]bool, up bool, steps int) ([]file.File, error) { | ||
| maxAlreadyMigrated := maxVersion(alreadyMigrated) |
There was a problem hiding this comment.
suggest to rename to maxMigratedVersion as it is first of all version
|
fixed |
andreigornostajev
approved these changes
Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.