Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfiles to use node 0.10* friendly versions of NPM modules. #75

Merged
merged 3 commits into from
May 3, 2018
Merged

Update Dockerfiles to use node 0.10* friendly versions of NPM modules. #75

merged 3 commits into from
May 3, 2018

Conversation

slime-horse
Copy link

PEPS Should be updated to work with an up to date version of node and up to date node modules for security reasons. However this PR fixes npm module version mismatches and targets node 0.10 friendly versions of modules.

Found the last version of each npm module used and targeted the last version of each before they upgraded to es2015.
@sdpoueme
Copy link

@grahm Nice update! Just tried and it fixes a lot of installation issues.

@hbi-wallix hbi-wallix merged commit 1a15c0f into wallix:master May 3, 2018
@slime-horse
Copy link
Author

@hbi-wallix This PR is a year old, PEPS needs to be updated to run on the latest stable version of nodejs with up to date modules. Locking modules down to node 0.10 was meant to be a short term fix.

@slime-horse
Copy link
Author

@hbi-wallix with the fixes from this #71 only the changes to use pre es2015 modules from #75 should be needed. It might be better to implement babeljs and update modules.

@hbi-wallix
Copy link
Contributor

Thanks @grahm for the comments.

I'll try to find some time again to build and launch it properly. Since we moved our focus, the project will not be maintained anymore but I wanted to leave it a stable state with fixed versions everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants