This repository has been archived by the owner on May 8, 2021. It is now read-only.
Add less than 2 seconds random waiting time in writerThread #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -290,7 +292,8 @@ class AppRuntime(appID: Int, | |||
| flushDirtySlateToCassandra() | |||
| debug("writeThread: flush dirty slates is done") | |||
| val exeuteTime = java.lang.System.currentTimeMillis - startTime | |||
| val sleepTime = appStatic.cassWriteInterval * 1000 - exeuteTime | |||
| // add around 2 seconds random sleep time | |||
| val sleepTime = appStatic.cassWriteInterval * 1000 - exeuteTime + (if (rand.nextBoolean) -(rand.nextInt & 0x7ff) else rand.nextInt & 0x7ff) | |||
There was a problem hiding this comment.
Is the seed to rand, randomly initialized? Also, I would prefer if the batch write were broken up into smaller chunks instead of the random skew in write time intervals.
|
The seed is inited once by system time in constructor. For now I don't see necessity to break one chunk write into smaller jobs since pelops.execute time is actually way much shorter than pelops.write time in our test. If in future we see any type of failure caused by size of writing chunk I definitely will think of using smaller size of writing job. |
sunweik
added a commit
that referenced
this pull request
Jul 2, 2013
Add less than 2 seconds random waiting time in writerThread
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.