Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mode for digital time display #1

Closed
walmik opened this issue Jan 27, 2014 · 4 comments
Closed

Add a mode for digital time display #1

walmik opened this issue Jan 27, 2014 · 4 comments
Labels
enhancement

Comments

@walmik
Copy link
Owner

walmik commented Jan 27, 2014

Add a digital mode for displaying time, like this

  1. 00:34
  2. 00:09:23
  3. 01:01:50:30
@ghost ghost assigned walmik Jan 27, 2014
@walmik walmik changed the title Add 2 modes for time display Add a mode for digital time display Dec 8, 2014
@walmik walmik mentioned this issue Jan 29, 2015
Closed
@yeruizhi
Copy link

This functionality is very helpful. Has it been done? Thanks.

@yeruizhi
Copy link

I read your code and find that function. I add another formatting function that output time in fixed "hh:mm:ss" format, like "00:00:01" .

@walmik
Copy link
Owner Author

walmik commented Feb 13, 2015

This functionality has not been implemented as yet. Please do feel free to submit a PR in case you do implement it :)

@walmik walmik mentioned this issue Mar 3, 2015
Closed
@walmik walmik removed their assignment Apr 1, 2015
@walmik
Copy link
Owner Author

walmik commented Apr 1, 2015

Closing this issue in favor of issue #36

@walmik walmik closed this as completed Apr 1, 2015
walmik pushed a commit that referenced this issue Jul 31, 2019
@mohitYogi @walmik
Updated timer to support continuous run (#1) (#92)
9b7c862 
* Updated timer to support continuous run (#1)

* Updated intervalHandler to support continuous run

intervalHandler is updated in order to support continuous timer run, even after duration is completed

* Flag for single call to callback

Flag for single call to callback when timer completes in continuous run.

* Update utils.js

* support continuous Timer run

1. Added stopTimerOnDuration in config to run timer continuously.
2. Updated intervalHandler to support continuous run
3. Added Flag isCallbackCalled to stop multiple calls to callback after reaching the duration in continuous run.

* Updates after review.

1. Removed stopTimerOnDuration flag (repeat flag do the same.)
2. Removed isCallbackCalled flag, as suggested after commit review.

* Update after Review

Removed flag isCallbackCalled. (Not required).

* Updates after review

1. Removed stopTimerOnDuration flag (repeat flag do the same.)
2. Removed isCallbackCalled flag, as suggested after commit review.

* Updates after Review

1. Removed stopTimerOnDuration flag (repeat flag do the same.)
2. Removed isCallbackCalled flag, as suggested after commit review.

* Patch version

New rule for checking timer duration completed.

* Update timer.jquery.js

* Semicolon & Comment update

Added missing semi colon. Updated Comment.

* Removed & Updated Comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@walmik @yeruizhi