Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compose config for linux #473

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix compose config for linux #473

merged 2 commits into from
Jun 6, 2024

Conversation

mikeplotean
Copy link
Contributor

@mikeplotean mikeplotean commented Jun 6, 2024

Having issuer-service.conf and verifier-service.conf baseUrl set to service names resulted in failing to get:
http://issuer-api:7002/.well-known/openid-credential-issuer
with NS_ERROR_UNKNOWN_HOST

So it was updated to host.docker.internal.
While this worked on Windows, on Linux it threw UnresolvedAddressException.

Adding extra-hosts for wallet-api service fixes it.

Steps to reproduce:

  1. run docker compose up
  2. open web-wallet (http://localhost:7101)
  3. issue a credential (http://localhost:7102)
  4. claim the credential offer with web-wallet

Expected:

  • Credential is claimed successfully
  • Credential is displayed in the web-wallet credential list

Actual:

  • Credential is not claimed
  • Browser console logs show BadRequest (400) error
  • Backend logs display UnresolvedAddressException

Acceptance criteria

Claiming works the same way on all environments:

  • Windows
  • Linux
  • MacOS

Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SuperBatata SuperBatata self-requested a review June 6, 2024 10:24
@mikeplotean
Copy link
Contributor Author

IMPORTANT! this is a temporary solution, until a proper one is found for the failing /.well-known/openid-credential-issuer request using service names.

@mikeplotean mikeplotean merged commit 0bc1268 into main Jun 6, 2024
6 checks passed
@mikeplotean mikeplotean deleted the unifx-compose-config branch June 6, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants