Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Background Playback no longer works on YouTube v18.27.32+ #155

Closed
badbeing opened this issue Jul 7, 2023 · 8 comments
Closed

Enable Background Playback no longer works on YouTube v18.27.32+ #155

badbeing opened this issue Jul 7, 2023 · 8 comments

Comments

@badbeing
Copy link

badbeing commented Jul 7, 2023

Since v18.27.32, when a user turns off their phone screen the video will automatically stop playing.
Device: Pixel 7 Pro

LSPosed logs:
LSPosed_2023-07-07T18_17_35.316819.zip

@thingo73
Copy link

That's right. I also have the same problem on Xiaomi 11. Hope the developer will fix it soon

@badbeing
Copy link
Author

badbeing commented Jul 10, 2023

There are perhaps some code changes from YouTube's side to make the feature unavailable, not sure. I downgraded the app version to v18.25.38 and it works.

@wanam
Copy link
Owner

wanam commented Jul 12, 2023

@badbeing according to your logs, the background patch seems to hook the correct class but the wrong method, unfortunately, I cannot help in the meanwhile, I won't be near my PC for the upcoming 4 weeks
I will take a look at it when I come back from vacation...

@badbeing
Copy link
Author

No worries, I've downgraded to a slightly older version since the module works perfectly fine there. Enjoy your vacation! 😄

@AllenChangMusic
Copy link

FYI, it started working for me again on version 18.28.33!
Not sure if they unintentionally broke something and fixed it.

@psychopathologist
Copy link

psychopathologist commented Jul 19, 2023

@badbeing according to your logs, the background patch seems to hook the correct class but the wrong method, unfortunately, I cannot help in the meanwhile, I won't be near my PC for the upcoming 4 weeks I will take a look at it when I come back from vacation...

First, enjoy your vacation!

In your code, the findAndHookVideoBGP4C method is hooking on a wrong class (adun), the correct one would be acxn. I've messed around with this here for a while, and I've been able to verify that such class has always no declared fields, so adding one more check to the code (below) did the trick here. Ofc you'll check and write something more elegant to handle with that!

if (aClass.getDeclaredFields().length > 1) return false;

@badbeing
Copy link
Author

I got tagged again by the previous comment lol. Anyway, just a small PSA that I have unrooted my device, so I no longer have access to any Xposed modules (especially the YouTube app is a system app on Pixels) and so I cannot perform any testing. 😔

@wanam
Copy link
Owner

wanam commented Sep 4, 2023

I tried the module today, and it seems to work fine against the latest YouTube version 18.34.37 I see on the Play Store.
Maybe it was related to some YouTube app changes that were discarded after 18.28.33 like @AllenChangMusic said in a previous comment #155 (comment)

@wanam wanam closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants