Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get version youtube A12 & added block general ads #123

Closed
wants to merge 2 commits into from

Conversation

Dev4Mod
Copy link

@Dev4Mod Dev4Mod commented Dec 22, 2022

I added code to block ads on home screen based on information present in revanced hope it can be accepted. Also fix issue getting youtube version on android 12

@wanam
Copy link
Owner

wanam commented Dec 23, 2022

Hello @Dev4Mod,

Thanks for your contribution! Unfortunately, it seems your changes are not working, at least with YouTube 17.46.xx.
By reading your changes, I see that you are using the same fingerprint to identify the ad classes, so I think you should add your ad processing inside the existing brute-force methods to reduce perf issues.

I will try (after vacations :) ) to merge those brute-force methods.

A scope resource is missing in your commit.

Copy link
Author

@Dev4Mod Dev4Mod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the problem with missing scope and improved the methods fetch code to work with version below 17.49

@wanam
Copy link
Owner

wanam commented Jan 2, 2023

Hello @Dev4Mod ,
Thank you again for your contribution, I didn't have much time to correctly test your changes- but it seems working so far.

I will have to try to improve the brute force perfs, to avoid getting the ad cards during the first load of the app, finding the hooks takes currently up to 10 seconds, we will need maybe to use shared prefs to avoid brute forcing on each reboot.

I merged off-line your commits with some minor changes, so I'm closing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants