Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): remove deadsnakes from accelerator build step #6933

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

bcsherma
Copy link
Contributor

@bcsherma bcsherma commented Feb 1, 2024

Description

This PR removes 3 commands from the accelerator build step. The first two steps add nvidia repos for installing cuda, but these are never used since we assume the base image has the accelerator libraries. The last step adds the deadsnakes ppa, which is a community library that enables installing specific patch versions (e.g. 3.9.12) of python. But the code also already resolves to a minor version (e.g. 3.9) which just works without the extra ppa.

The problem in the linked ticket was caused by the use of the add-apt-repository command, which is an extension of apt that is not widely compatible with debian container images.

Testing

How was this PR tested?

@github-actions github-actions bot added the cc-fix label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f0150a) 79.68% compared to head (ccd3fe8) 76.95%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6933      +/-   ##
==========================================
- Coverage   79.68%   76.95%   -2.74%     
==========================================
  Files         462      462              
  Lines       52747    52747              
==========================================
- Hits        42033    40593    -1440     
- Misses      10416    11848    +1432     
- Partials      298      306       +8     
Flag Coverage Δ
func 48.51% <ø> (-0.19%) ⬇️
system 60.67% <ø> (-1.34%) ⬇️
unit 56.22% <ø> (-3.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/launch/builder/build.py 85.28% <ø> (ø)

... and 61 files with indirect coverage changes

@github-actions github-actions bot added cc-fix and removed cc-fix labels Feb 1, 2024
@bcsherma bcsherma merged commit f8625f9 into main Feb 5, 2024
78 of 79 checks passed
@bcsherma bcsherma deleted the launch/fix-accelerator-build branch February 5, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants