Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): exercise caution in system monitor when rocm-smi is installed on a system with no amd gpus #6938

Merged
merged 5 commits into from
Feb 3, 2024

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Feb 2, 2024

Description

What does the PR do?

Include a concise description of the PR contents

Testing

How was this PR tested?

@github-actions github-actions bot added the cc-fix label Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (2165475) 79.71% compared to head (74954a1) 76.66%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6938      +/-   ##
==========================================
- Coverage   79.71%   76.66%   -3.06%     
==========================================
  Files         462      462              
  Lines       52685    52721      +36     
==========================================
- Hits        41999    40417    -1582     
- Misses      10391    12006    +1615     
- Partials      295      298       +3     
Flag Coverage Δ
func 47.36% <17.02%> (-1.40%) ⬇️
system 57.86% <17.02%> (-4.12%) ⬇️
unit 59.25% <23.40%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/internal/system/assets/gpu_amd.py 76.98% <23.80%> (-9.86%) ⬇️
core/pkg/monitor/gpu_amd.go 74.55% <23.07%> (-6.95%) ⬇️

... and 76 files with indirect coverage changes

Copy link
Collaborator

@kptkin kptkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@dmitryduev dmitryduev requested a review from a team as a code owner February 2, 2024 20:48
@github-actions github-actions bot added cc-fix and removed cc-fix labels Feb 3, 2024
@dmitryduev dmitryduev merged commit b4553d2 into main Feb 3, 2024
73 of 81 checks passed
@dmitryduev dmitryduev deleted the fix-amd-gpu branch February 3, 2024 00:20
@github-actions github-actions bot added cc-fix and removed cc-fix labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI]: WARNING: No AMD GPUs specified
2 participants