chore(weave): Add a fast path for simple queries #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=55e382af36be603df6a9cb6b3d99618ce334bbcc |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=48cad5d163a1a13b20f6cc40b5b9e1ab2d1cdf76 |
3 similar comments
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=48cad5d163a1a13b20f6cc40b5b9e1ab2d1cdf76 |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=48cad5d163a1a13b20f6cc40b5b9e1ab2d1cdf76 |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=48cad5d163a1a13b20f6cc40b5b9e1ab2d1cdf76 |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=cfd46c78c14a8c785b5e26b47c0c536cf2f62451 |
…fast_path_to_queries
tssweeney
changed the base branch from
master
to
tim/add_project_id_to_inner_conditions
shawnlewis
approved these changes
Jun 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #1715 ... another step in making queries faster! In this PR, we take advantage of the case where there are no group-by conditions. In such cases we can push the sort/limit down into an inner-clause.
This PR does 1 thing:
having_conditionsand we only need to sort based on data in 1 event type or the other (start or end), then we can use a fast path that pushes the sort condition down to the inner clause, avoiding extra aggregations!