chore(weave): Tests for Threading Support #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=5b66812d276d9f26f02fce50e9c075fd848a284f |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=d077da521a8d1312313d3377ab97df3c215295ea |
tssweeney
changed the title
gtarpenning
approved these changes
Jun 11, 2024
totally agreed. I have been shoving everything in this test file so it is easier to keep track of what is "new weave" vs "old weave"... sigh... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to be modifying how our context state / stack is managed across threads in the near-term. I wanted to make sure the desired behavior is properly tested. This new test has 3 flavors (1 of which is commented out because it current fails!).
When we fix threading support, we should be able to uncomment out and enable this test.